Greptile Summary

This PR fixes a false-positive "Pending deploy" indicator that persisted permanently when the "Enrich with VectorFlow metadata" option was enabled on a pipeline. The root cause was that the hasUndeployedChanges comparison in pipeline.list was calling generateVectorYaml() without the enrichment parameter, producing YAML that was structurally different from the stored configYaml (which included the injected vectorflow_metadata_enrich transform), even when no real changes existed.

Key changes:

• Added enrichMetadata and environment: { select: { name: true } } to the Prisma select in pipeline.list so the enrichment context is available during comparison.
• Constructs the same enrichment object (using latestVersion.version — the deployed version number — and p.environment.name) that was used by createVersion's builder function at deploy time, and passes it to generateVectorYaml for the comparison.

Correctness of the approach: The deployed YAML stored in latestVersion.configYaml is generated with pipelineVersion = N (the version number atomically assigned when the PipelineVersion row is created). By using latestVersion.version (= N) in the comparison, both sides of the equality check now use identical enrichment parameters when no real changes have been made, resolving the false positive.

Confidence Score: 5/5

• This PR is safe to merge — it is a targeted, correct fix with no security or data-integrity implications.
• The change is minimal and well-reasoned. The comparison now uses the same pipelineVersion (the already-deployed version number from latestVersion.version) and environmentName that were embedded into the stored YAML at deploy time, making the two sides of the equality check symmetric. No new DB queries are added (fields are included in the existing Prisma select), no mutations are changed, and the fix does not affect the deploy path itself. The environment relation is a required FK so p.environment.name is always safe to access.
• No files require special attention.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant User
    participant PipelineList as pipeline.list (tRPC)
    participant DeployAgent as deploy.agent (tRPC)
    participant CreateVersion as createVersion()
    participant GenYaml as generateVectorYaml()
    participant DB as PostgreSQL

    Note over DeployAgent,CreateVersion: At deploy time (enrichMetadata = true)
    DeployAgent->>GenYaml: generateVectorYaml(nodes, edges, globalConfig, {environmentName, pipelineVersion: N+1})
    GenYaml-->>DeployAgent: configYaml (with .vectorflow.pipeline_version = N+1)
    DeployAgent->>CreateVersion: createVersion(pipelineId, (v) => buildYaml(v), ...)
    CreateVersion->>GenYaml: builder(N+1) → YAML embedded with version N+1
    CreateVersion->>DB: PipelineVersion { version: N+1, configYaml: "...pipeline_version = N+1..." }

    Note over PipelineList,DB: At pipeline.list query time (BEFORE this fix)
    PipelineList->>DB: SELECT latestVersion (version=N+1, configYaml)
    PipelineList->>GenYaml: generateVectorYaml(nodes, edges, globalConfig, null)
    GenYaml-->>PipelineList: currentYaml (NO enrichment transform)
    PipelineList->>PipelineList: currentYaml ≠ latestVersion.configYaml → hasUndeployedChanges = TRUE (false positive!)

    Note over PipelineList,DB: At pipeline.list query time (AFTER this fix)
    PipelineList->>DB: SELECT latestVersion (version=N+1, configYaml) + enrichMetadata + environment.name
    PipelineList->>GenYaml: generateVectorYaml(nodes, edges, globalConfig, {environmentName, pipelineVersion: N+1})
    GenYaml-->>PipelineList: currentYaml (with matching enrichment transform)
    PipelineList->>PipelineList: currentYaml === latestVersion.configYaml → hasUndeployedChanges = FALSE ✓

_{Last reviewed commit: 13797b3}